Add Hugging Face organization slug helper under Allowed organization#2600
Merged
google-oss-prow[bot] merged 3 commits intokubeflow:mainfrom Apr 21, 2026
Merged
Add Hugging Face organization slug helper under Allowed organization#2600google-oss-prow[bot] merged 3 commits intokubeflow:mainfrom
google-oss-prow[bot] merged 3 commits intokubeflow:mainfrom
Conversation
Closed
7 tasks
manaswinidas
suggested changes
Apr 16, 2026
| 'Enter the name of the organization (for example, meta-llama) to sync models from. Hugging Face sources are limited to 1 organization to prevent performance issues related to loading large model sets.', | ||
| YAML: 'Upload or paste a YAML string.', | ||
| ORGANIZATION_SLUG: | ||
| 'Hugging Face organization’s name is case-sensitive and match the organization’s URL, which may differ from the displayed name. Use the organization’s URL slug found in the URL (e.g., Input: meta-llama from huggingface.co/meta-llama).', |
Contributor
There was a problem hiding this comment.
Suggested change
| 'Hugging Face organization’s name is case-sensitive and match the organization’s URL, which may differ from the displayed name. Use the organization’s URL slug found in the URL (e.g., Input: meta-llama from huggingface.co/meta-llama).', | |
| 'Hugging Face organization’s name is case-sensitive and should match the organization’s URL, which may differ from the displayed name. Use the organization’s URL slug found in the URL (e.g., Input: meta-llama from huggingface.co/meta-llama).', |
grammatical correction
Philip-Carneiro
suggested changes
Apr 16, 2026
Comment on lines
+91
to
+105
| <ThemeAwareFormGroupWrapper | ||
| label={FORM_LABELS.ORGANIZATION} | ||
| fieldId="organization" | ||
| isRequired | ||
| descriptionTextNode={organizationDescriptionTxtNode} | ||
| helperTextNode={organizationHelperTxtNode} | ||
| > | ||
| {organizationInput} | ||
| </ThemeAwareFormGroupWrapper> | ||
| <FormHelperText> | ||
| <HelperText> | ||
| <HelperTextItem>{HELP_TEXT.ORGANIZATION_SLUG}</HelperTextItem> | ||
| </HelperText> | ||
| </FormHelperText> | ||
| </> |
Contributor
There was a problem hiding this comment.
This PR will conflict with #2526 and will break the logic added there
Comment on lines
+42
to
+43
| ORGANIZATION_SLUG: | ||
| 'Hugging Face organization’s name is case-sensitive and should match the organization’s URL, which may differ from the displayed name. Use the organization’s URL slug found in the URL (e.g., Input: meta-llama from huggingface.co/meta-llama).', |
Contributor
There was a problem hiding this comment.
This will have the same problem from the previous comment, it should wait for the merge of #2526 and add following the const and logic there
Contributor
|
@Philip-Carneiro: changing LGTM is restricted to collaborators DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
github-actions
Bot
added
size/S
Area/GitHub
Area/Manifests
Area/Jobs/Async-upload
and removed
size/XXL
labels
Signed-off-by: Taj010 <rsheen003@gmail.com>
Signed-off-by: Taj010 <rsheen003@gmail.com>
Signed-off-by: Taj010 <rsheen003@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manaswinidas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds secondary helper text below the Allowed organization field on the Hugging Face catalog source form. This text will inform the administrator that the display name and organization name may differ and provide guidance on locating the correct organization name.
How Has This Been Tested?
This has been tested by navigating to
model-catalog-settings/add-sourceand ensuring the helper text is visible under the organization input field.Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes